fix: schedule task name for closures and invokable objects #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
countless-integers
approved these changes
Nov 7, 2022
| } catch (ClientException $exception) { | ||
| Log::error($exception, ['api_response' => (string) $exception->getResponse()->getBody()]); | ||
| } catch (Throwable $t) { | ||
| } catch (\Throwable $t) { |
There was a problem hiding this comment.
This looked better before -- is this why the linter complained? Very, very weird.
There was a problem hiding this comment.
Yes, we were a few versions behind and looks like they changed the default a couple of weeks ago.
There was a problem hiding this comment.
They didn't much of an explanation after I followed the thread to this comment. Must be a Symfony thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our implementation to get the transaction name for Scheduled Tasks, was expecting only commands, but it should also accepts closures, invokable objects and jobs. I took the implementation that Laravel uses to print the scheduled name in the terminal.
The linter was complaining, sorry for the extra diff.
Closes #171